Review Request 123737: Use QTemporaryFile instead of hardcoding a temporary file
Michael Palimaka
kensington at gentoo.org
Wed May 13 17:13:04 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123737/
-----------------------------------------------------------
(Updated May 13, 2015, 5:13 p.m.)
Review request for KDE Frameworks.
Changes
-------
Eliminate ifdefs.
Repository: kdelibs4support
Description
-------
Hardcoding files like this seems like a bad idea. Also updates the source URL to something fetchable.
This also affects kdelibs.
Diffs (updated)
-----
tests/netaccesstest.cpp a06b49d015fe420fd0293292041caa988422f521
Diff: https://git.reviewboard.kde.org/r/123737/diff/
Testing
-------
Test still passes on Linux. Can't test on Windows.
Thanks,
Michael Palimaka
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150513/f98dab3b/attachment.html>
More information about the Kde-frameworks-devel
mailing list