Review Request 123737: Use QTemporaryFile instead of hardcoding a temporary file

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123737/#review80263
-----------------------------------------------------------



tests/netaccesstest.cpp (line 39)
<https://git.reviewboard.kde.org/r/123737/#comment55059>

    Use QUrl::fromLocalFile and remove the ifdef.


- Aleix Pol Gonzalez


On May 12, 2015, 7:12 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123737/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 7:12 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> Hardcoding files like this seems like a bad idea. Also updates the source URL to something fetchable.
> 
> This also affects kdelibs.
> 
> 
> Diffs
> -----
> 
>   tests/netaccesstest.cpp a06b49d015fe420fd0293292041caa988422f521 
> 
> Diff: https://git.reviewboard.kde.org/r/123737/diff/
> 
> 
> Testing
> -------
> 
> Test still passes on Linux. Can't test on Windows.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150512/a1098345/attachment.html>