Review Request 123745: Stop producing warnings about CMP0037 policy
Hrvoje Senjan
hrvoje.senjan at gmail.com
Wed May 13 00:26:36 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123745/
-----------------------------------------------------------
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Repository: kauth
Description
-------
Let cmake know ALL is not the name in this custom command. As a bonus, one can really execute make ${HELPER_ID}.policy in projects where policies are generated by kauth.
Diffs
-----
cmake/KF5AuthMacros.cmake 3508236
Diff: https://git.reviewboard.kde.org/r/123745/diff/
Testing
-------
Configured powerdevil, no warning, before it nagged:
```
[ 110s] CMake Warning (dev) at /usr/lib64/cmake/KF5Auth/KF5AuthMacros.cmake:76 (add_custom_target):
[ 110s] Policy CMP0037 is not set: Target names should not be reserved and should
[ 110s] match a validity pattern. Run "cmake --help-policy CMP0037" for policy
[ 110s] details. Use the cmake_policy command to set the policy and suppress this
[ 110s] warning.
[ 110s]
[ 110s] The target name "actions for org.kde.powerdevil.backlighthelper" is
[ 110s] reserved or not valid for certain CMake features, such as generator
[ 110s] expressions, and may result in undefined behavior.
[ 110s] Call Stack (most recent call first):
[ 110s] daemon/BackendConfig.cmake:46 (kauth_install_actions)
[ 110s] daemon/CMakeLists.txt:96 (include)
```
Also make org.kde.powerdevil.backlighthelper.policy now works.
Thanks,
Hrvoje Senjan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150513/08c2ee28/attachment.html>
More information about the Kde-frameworks-devel
mailing list