<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123745/">https://git.reviewboard.kde.org/r/123745/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Aleix Pol Gonzalez.</div>
<div>By Hrvoje Senjan.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kauth
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Let cmake know ALL is not the name in this custom command. As a bonus, one can really execute make ${HELPER_ID}.policy in projects where policies are generated by kauth.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Configured powerdevil, no warning, before it nagged:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">[ 110s] CMake Warning (dev) at /usr/lib64/cmake/KF5Auth/KF5AuthMacros.cmake:76 (add_custom_target):
[ 110s] Policy CMP0037 is not set: Target names should not be reserved and should
[ 110s] match a validity pattern. Run "cmake --help-policy CMP0037" for policy
[ 110s] details. Use the cmake_policy command to set the policy and suppress this
[ 110s] warning.
[ 110s]
[ 110s] The target name "actions for org.kde.powerdevil.backlighthelper" is
[ 110s] reserved or not valid for certain CMake features, such as generator
[ 110s] expressions, and may result in undefined behavior.
[ 110s] Call Stack (most recent call first):
[ 110s] daemon/BackendConfig.cmake:46 (kauth_install_actions)
[ 110s] daemon/CMakeLists.txt:96 (include)
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also make org.kde.powerdevil.backlighthelper.policy now works.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/KF5AuthMacros.cmake <span style="color: grey">(3508236)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123745/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>