Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.
Jeremy Whiting
jpwhiting at kde.org
Tue May 12 23:46:03 UTC 2015
> On May 12, 2015, 4:49 p.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 32
> > <https://git.reviewboard.kde.org/r/123742/diff/1/?file=368438#file368438line32>
> >
> > Do you think this is needed? It's REQUIRED anyway.
Oops, I did this wrong, I'll update the patch in a bit at home.
the point of the early feature summary is to explain what ecm is when it is missing.
- Jeremy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123742/#review80264
-----------------------------------------------------------
On May 12, 2015, 3:19 p.m., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123742/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 3:19 p.m.)
>
>
> Review request for KDE Frameworks and Jeremy Whiting.
>
>
> Repository: knewstuff
>
>
> Description
> -------
>
> Add verbose ecm message when ECM isn't found.
>
>
> Diffs
> -----
>
> CMakeLists.txt cb23ccb8a9b0421a554b41234c3d9ced3965d378
>
> Diff: https://git.reviewboard.kde.org/r/123742/diff/
>
>
> Testing
> -------
>
> KNewStuff (and any other framework we add these changes to) now reports the ECM url and name when it isn't found at cmake time.
>
>
> Thanks,
>
> Jeremy Whiting
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150512/0c2e084d/attachment.html>
More information about the Kde-frameworks-devel
mailing list