Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

Aleix Pol Gonzalez aleixpol at kde.org
Tue May 12 22:49:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123742/#review80264
-----------------------------------------------------------



CMakeLists.txt (line 32)
<https://git.reviewboard.kde.org/r/123742/#comment55061>

    Do you think this is needed? It's REQUIRED anyway.



CMakeLists.txt (line 33)
<https://git.reviewboard.kde.org/r/123742/#comment55060>

    The feature_summary should go at the end.


- Aleix Pol Gonzalez


On May 12, 2015, 11:19 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123742/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 11:19 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> Add verbose ecm message when ECM isn't found.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt cb23ccb8a9b0421a554b41234c3d9ced3965d378 
> 
> Diff: https://git.reviewboard.kde.org/r/123742/diff/
> 
> 
> Testing
> -------
> 
> KNewStuff (and any other framework we add these changes to) now reports the ECM url and name when it isn't found at cmake time.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150512/55618a53/attachment.html>


More information about the Kde-frameworks-devel mailing list