Review Request 123654: Improve performance of KFileItem and KDirSortFilterProxyModel

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123654/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kio


Description
-------

Reduces some operations in KDirSortFilterProxyModel.
Removes usage of QUrl::fileName() in KFileItem::isHidden(), it comprised 75% of the time spent running the benchmark in here.


Diffs
-----

  autotests/CMakeLists.txt 010074d 
  autotests/kdirsortfilterproxymodel_benchmark.cpp PRE-CREATION 
  src/core/kfileitem.cpp 344ac67 
  src/filewidgets/kdirsortfilterproxymodel.cpp 22ac025 

Diff: https://git.reviewboard.kde.org/r/123654/diff/


Testing
-------

Everything seems to be working still, including tests.

There was a comment about trash:/ triggering an assert, but I couldn't reproduce.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150506/f61f7e10/attachment.html>