Review Request 123111: Only add a '/' if the url does not end with one

Àlex Fiestas afiestas at kde.org
Tue May 5 12:44:05 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123111/
-----------------------------------------------------------

(Updated May 5, 2015, 12:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 6788bacc9f8eb593e67e3264177d49d45eb1ddf4 by Aleix Pol to branch master.


Repository: frameworkintegration


Description
-------

I could not figure out any other way of knowing if the path ends with '/' than calling toString so that is what I am doing.

This patch adds a test with 3 different data that now behave correctly, before smb: and smb:// were failing.


Diffs
-----

  autotests/CMakeLists.txt e8ed6a9 
  autotests/kdirselectdialog_unittest.cpp PRE-CREATION 
  src/platformtheme/kdirselectdialog.cpp 9a4082a 
  src/platformtheme/kdirselectdialog_p.h 8b5c77a 

Diff: https://git.reviewboard.kde.org/r/123111/diff/


Testing
-------


Thanks,

Àlex Fiestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150505/91b4e51a/attachment.html>


More information about the Kde-frameworks-devel mailing list