Review Request 123601: Fix ambiguous shortcuts error message in applications caused by duplicate entries in QList<QKeySequence>

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123601/#review79797
-----------------------------------------------------------


Why not at least allow people to write 3 shortcuts in a .rc file, when setting things up by hand?

I think this patch mixes two things, fixing a duplication bug, and adding a limitation to 2 entries in the list.

Maybe one day the GUI could allow more than two shortcuts, too.

- David Faure


On May 3, 2015, 2:46 p.m., Mladen Milinkovic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123601/
> -----------------------------------------------------------
> 
> (Updated May 3, 2015, 2:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 343665
>     https://bugs.kde.org/show_bug.cgi?id=343665
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> After customizing shortcut with KShortcutsDialog it prepends Primary and Alternate QKeySequence to QList<QKeySequence> without removing old QKeySequences.
> QList<QKeySequence> after awhile becomes a long list of duplicate QKeySequence and those cannot be removed without editing .rc file.
> Pressing keyboard shortcuts in applications shows Ambiguous Shortcut error.
> 
> This patch removes all QKeySequences in QList except first two, which are only that are editable from KShortcutsDialog.
> 
> 
> Diffs
> -----
> 
>   src/kactioncollection.cpp 9c45725 
>   src/kxmlguifactory.cpp a4305a4 
> 
> Diff: https://git.reviewboard.kde.org/r/123601/diff/
> 
> 
> Testing
> -------
> 
> Tested most of KDE applications and it solves the issue, keyboard shortcuts work just fine and annoying error message is no more.
> 
> 
> Thanks,
> 
> Mladen Milinkovic
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150503/85a99957/attachment-0001.html>