Review Request 123601: Fix ambiguous shortcuts error message in applications caused by duplicate entries in QList<QKeySequence>

[Mladen Milinkovic]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123601/
-----------------------------------------------------------

(Updated May 3, 2015, 2:46 p.m.)


Review request for KDE Frameworks.


Bugs: 343665
    https://bugs.kde.org/show_bug.cgi?id=343665


Repository: kxmlgui


Description (updated)
-------

After customizing shortcut with KShortcutsDialog it prepends Primary and Alternate QKeySequence to QList<QKeySequence> without removing old QKeySequences.
QList<QKeySequence> after awhile becomes a long list of duplicate QKeySequence and those cannot be removed without editing .rc file.
Pressing keyboard shortcuts in applications shows Ambiguous Shortcut error.

This patch removes all QKeySequences in QList except first two, which are only that are editable from KShortcutsDialog.


Diffs
-----

  src/kactioncollection.cpp 9c45725 
  src/kxmlguifactory.cpp a4305a4 

Diff: https://git.reviewboard.kde.org/r/123601/diff/


Testing
-------

Tested most of KDE applications and it solves the issue, keyboard shortcuts work just fine and annoying error message is no more.


Thanks,

Mladen Milinkovic

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150503/d3a23659/attachment.html>