Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)
Àlex Fiestas
afiestas at kde.org
Mon Mar 23 00:34:01 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122613/
-----------------------------------------------------------
(Updated March 23, 2015, 12:34 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Changes
-------
Submitted with commit f00990e3a5b7178d75278429c426fc9d953d49de by Àlex Fiestas to branch master.
Repository: kio
Description
-------
The rest of kio internally is doing this correctly apparently it was only a problem in the GUI part of it.
Diffs
-----
autotests/CMakeLists.txt 69c8957
autotests/kurlcomboboxtest.h PRE-CREATION
autotests/kurlcomboboxtest.cpp PRE-CREATION
src/widgets/kurlcombobox.cpp ed5b8a2
Diff: https://git.reviewboard.kde.org/r/122613/diff/
Testing
-------
Besides the added unit tests, I have used this patch while running a few ups, everything seems to work great.
Thanks,
Àlex Fiestas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150323/a6ed7dcd/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list