Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)
David Faure
faure at kde.org
Sun Mar 22 17:26:14 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122613/#review77921
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On March 22, 2015, 5:25 p.m., Àlex Fiestas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122613/
> -----------------------------------------------------------
>
> (Updated March 22, 2015, 5:25 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> The rest of kio internally is doing this correctly apparently it was only a problem in the GUI part of it.
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 69c8957
> autotests/kurlcomboboxtest.h PRE-CREATION
> autotests/kurlcomboboxtest.cpp PRE-CREATION
> src/widgets/kurlcombobox.cpp ed5b8a2
>
> Diff: https://git.reviewboard.kde.org/r/122613/diff/
>
>
> Testing
> -------
>
> Besides the added unit tests, I have used this patch while running a few ups, everything seems to work great.
>
>
> Thanks,
>
> Àlex Fiestas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150322/1a82a1e5/attachment.html>
More information about the Kde-frameworks-devel
mailing list