Review Request 122313: Expose to world whether KPty has been built with utempter library

Hrvoje Senjan hrvoje.senjan at gmail.com
Thu Mar 19 11:18:05 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122313/
-----------------------------------------------------------

(Updated March 19, 2015, 11:18 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
-------

Submitted with commit acf078d84d8f1c4d5fcf28cf9a9f570760ba1501 by Hrvoje Senjan to branch master.


Repository: kpty


Description
-------

Equivalent to https://svn.reviewboard.kde.org/r/2468/
It was lost in KF5 porting, and it was directly used to determine whether kwrited should be built as module, or executable (in this case, it would be a SUID binary, which Qt5 no longer -by default- allows)


Diffs
-----

  CMakeLists.txt 7fe77da7b0bc97c6f64db4fcc63ef7831fa065b1 
  KF5PtyConfig.cmake.in 04bde7bffd209b57e755a66278025ee8b6453770 
  cmake/FindUTEMPTER.cmake PRE-CREATION 
  src/CMakeLists.txt caf2f0ba87ad4173af9860ae369b43d50ffd219f 
  src/ConfigureChecks.cmake f52be3f5e031c73dd7d26296622c14c9d69db42c 

Diff: https://git.reviewboard.kde.org/r/122313/diff/


Testing
-------

built, cmake configuration looks ok.


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150319/2009f13c/attachment.html>


More information about the Kde-frameworks-devel mailing list