Review Request 122313: Expose to world whether KPty has been built with utempter library

David Faure faure at kde.org
Thu Mar 19 09:39:24 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122313/#review77724
-----------------------------------------------------------

Ship it!


- David Faure


On Jan. 29, 2015, 6:54 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122313/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2015, 6:54 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kpty
> 
> 
> Description
> -------
> 
> Equivalent to https://svn.reviewboard.kde.org/r/2468/
> It was lost in KF5 porting, and it was directly used to determine whether kwrited should be built as module, or executable (in this case, it would be a SUID binary, which Qt5 no longer -by default- allows)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7fe77da7b0bc97c6f64db4fcc63ef7831fa065b1 
>   KF5PtyConfig.cmake.in 04bde7bffd209b57e755a66278025ee8b6453770 
>   cmake/FindUTEMPTER.cmake PRE-CREATION 
>   src/CMakeLists.txt caf2f0ba87ad4173af9860ae369b43d50ffd219f 
>   src/ConfigureChecks.cmake f52be3f5e031c73dd7d26296622c14c9d69db42c 
> 
> Diff: https://git.reviewboard.kde.org/r/122313/diff/
> 
> 
> Testing
> -------
> 
> built, cmake configuration looks ok.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150319/de2850e1/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list