Review Request 122770: Support KWindowSystem::icon with NETWinInfo on all platforms

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122770/
-----------------------------------------------------------

(Updated March 16, 2015, 9:42 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 3306777fe098720238c2e28992b4b21bdea25511 by Martin Gräßlin to branch master.


Repository: kwindowsystem


Description
-------

If we compile with X11 support we want this method to use the X11
implementation on all platforms and not just on platform xcb. The
NETWinInfo is already so X11 specific that the platform doesn't
matter.

To solve this the method it delegates to in KWindowSystemPrivateX11
is made static. It only operates through the NETWinInfo and doesn't
need anything else from KWindowSystemPrivateX11.


Diffs
-----

  src/kwindowsystem.h 21b254b246753d6ee7805864e28284dfa169855e 
  src/kwindowsystem.cpp 97dd6072a77f864b1e08287e8546cc29c24474c6 
  src/kwindowsystem_p_x11.h a507922ba632eb54e9121a1420d83c26d3676c66 

Diff: https://git.reviewboard.kde.org/r/122770/diff/


Testing
-------

kwin_wayland (Martin dev branch) shows icons for X11 applications again.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150316/44bf2a90/attachment.html>