Review Request 122706: A KCModule base for QML based KCMs
David Edmundson
david at davidedmundson.co.uk
Mon Mar 2 10:16:00 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122706/#review76873
-----------------------------------------------------------
+1
- David Edmundson
On Feb. 25, 2015, 5:40 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122706/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 5:40 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kconfigwidgets
>
>
> Description
> -------
>
> this adds a new class called KCModuleQml
> it loads a KPackage with the same plugin name as the kcm, then loads its mainscript qml file from it and puts it in a QQuickView used as main widget of the KCM.
>
> It supports two ways of loading the qml:
> one is in the showevent of the KCM qwidget, this is compatible with current Systemsettings and kcmshell.
> the other way is with the mainUi accessor/qproperty. This will make possible for a pure QML version of systemsettings (accessing directly mainUi without showing qwidgets)
>
>
> Diffs
> -----
>
> CMakeLists.txt f3aaf18
> src/CMakeLists.txt 10862c6
> src/kcmoduleqml.h PRE-CREATION
> src/kcmoduleqml.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/122706/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150302/4f3d8388/attachment.html>
More information about the Kde-frameworks-devel
mailing list