Review Request 122926: Add setError method to JobViewV2 interface

David Rosca nowrep at gmail.com
Fri Mar 13 19:26:05 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122926/
-----------------------------------------------------------

(Updated March 13, 2015, 7:26 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 812d0b440e7f08e3acdd1c9bb95779bd871b75b3 by David Rosca to branch master.


Repository: kjobwidgets


Description
-------

Currently, there is no way to retrieve value of KJob::error().
This patch adds a setError method to JobViewV2 interface that fixes the issue.

This is needed to correctly handle job errors in notifications plasmoid.
If this gets accepted, I will create a review request for plasma-workspace (changes in kuiserver, dataengine and notifications plasmoid).


Diffs
-----

  src/kuiserverjobtracker.cpp 191359b 
  src/org.kde.JobViewV2.xml cacb5e8 

Diff: https://git.reviewboard.kde.org/r/122926/diff/


Testing
-------

Works fine with patched plasma-workspace


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150313/26b97137/attachment.html>


More information about the Kde-frameworks-devel mailing list