Review Request 122926: Add setError method to JobViewV2 interface

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122926/#review77407
-----------------------------------------------------------

Ship it!


OK. This could have been part of the terminate call, but for compat reasons it's simpler to just add a setter indeed.

- David Faure


On March 12, 2015, 10:03 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122926/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 10:03 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> -------
> 
> Currently, there is no way to retrieve value of KJob::error().
> This patch adds a setError method to JobViewV2 interface that fixes the issue.
> 
> This is needed to correctly handle job errors in notifications plasmoid.
> If this gets accepted, I will create a review request for plasma-workspace (changes in kuiserver, dataengine and notifications plasmoid).
> 
> 
> Diffs
> -----
> 
>   src/kuiserverjobtracker.cpp 191359b 
>   src/org.kde.JobViewV2.xml cacb5e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122926/diff/
> 
> 
> Testing
> -------
> 
> Works fine with patched plasma-workspace
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150313/a5e819ab/attachment.html>