Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave
Emmanuel Pescosta
emmanuelpescosta099 at gmail.com
Sat Mar 7 11:40:57 UTC 2015
> On March 7, 2015, 11:05 a.m., David Faure wrote:
> > sftp/kio_sftp.h, line 215
> > <https://git.reviewboard.kde.org/r/122621/diff/1/?file=350140#file350140line215>
> >
> > not really a todo for this particular class then, it wouldn't change ;)
Just copied the comment from smb ioslave, but I agree that this comment is really bad -> changed it ;)
- Emmanuel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122621/#review77155
-----------------------------------------------------------
On Feb. 18, 2015, 12:14 p.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122621/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 12:14 p.m.)
>
>
> Review request for KDE Frameworks and Andreas Schneider.
>
>
> Repository: kio-extras
>
>
> Description
> -------
>
> Implemented SlaveBase::GetFileSystemFreeSpace to enable free space information in sftp ioslave.
>
>
> Diffs
> -----
>
> sftp/kio_sftp.h e088472
> sftp/kio_sftp.cpp 057fcd4
>
> Diff: https://git.reviewboard.kde.org/r/122621/diff/
>
>
> Testing
> -------
>
> Works
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150307/7cda8ead/attachment.html>
More information about the Kde-frameworks-devel
mailing list