Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

David Faure faure at kde.org
Sat Mar 7 10:05:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122621/#review77155
-----------------------------------------------------------

Ship it!



sftp/kio_sftp.h
<https://git.reviewboard.kde.org/r/122621/#comment53010>

    not really a todo for this particular class then, it wouldn't change ;)



sftp/kio_sftp.cpp
<https://git.reviewboard.kde.org/r/122621/#comment53011>

    no space before ", qCDebug will add one already.


- David Faure


On Feb. 18, 2015, 11:14 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122621/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2015, 11:14 a.m.)
> 
> 
> Review request for KDE Frameworks and Andreas Schneider.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Implemented SlaveBase::GetFileSystemFreeSpace to enable free space information in sftp ioslave.
> 
> 
> Diffs
> -----
> 
>   sftp/kio_sftp.h e088472 
>   sftp/kio_sftp.cpp 057fcd4 
> 
> Diff: https://git.reviewboard.kde.org/r/122621/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150307/7965a4ed/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list