Review Request 122614: Fix a porting bug in the http ioslave

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122614/#review77153
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On March 7, 2015, 9:29 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122614/
> -----------------------------------------------------------
> 
> (Updated March 7, 2015, 9:29 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Fix the file/directory name extraction + base dir handling in the http ioslave
> 
> "name" was always empty for directories because thisURL ends with a slash and fileName() will return an empty string, so href.text() was used as UDS_NAME instead.
> 
> 
> Diffs
> -----
> 
>   src/ioslaves/http/http.cpp 78f50f9 
> 
> Diff: https://git.reviewboard.kde.org/r/122614/diff/
> 
> 
> Testing
> -------
> 
> Works (see screenshots)
> 
> 
> File Attachments
> ----------------
> 
> Webdav (Bug)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/18/d0ae2572-3770-4781-88e3-4d40e626fd85__webdav_bug.png
> Webdav (Fixed)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/18/de96eb2e-45d8-4388-83b6-77199f677c75__webdav_fixed.png
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150307/b696ed38/attachment.html>