Review Request 122614: Fix a porting bug in the http ioslave

[Emmanuel Pescosta]

> On March 7, 2015, 10:42 a.m., David Faure wrote:
> > src/ioslaves/http/http.cpp, line 854
> > <https://git.reviewboard.kde.org/r/122614/diff/1/?file=350094#file350094line854>
> >
> >     I don't like the use of section, when we have QUrl API to do this cleanly.
> >     
> >     Store thisURL.adjusted(StripTrailingSlash), and use fileName() on that?
> 
> David Faure wrote:
>     Heh ok race condition ;)

Fixed 14 minutes ago :)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122614/#review77150
-----------------------------------------------------------


On March 7, 2015, 10:29 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122614/
> -----------------------------------------------------------
> 
> (Updated March 7, 2015, 10:29 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Fix the file/directory name extraction + base dir handling in the http ioslave
> 
> "name" was always empty for directories because thisURL ends with a slash and fileName() will return an empty string, so href.text() was used as UDS_NAME instead.
> 
> 
> Diffs
> -----
> 
>   src/ioslaves/http/http.cpp 78f50f9 
> 
> Diff: https://git.reviewboard.kde.org/r/122614/diff/
> 
> 
> Testing
> -------
> 
> Works (see screenshots)
> 
> 
> File Attachments
> ----------------
> 
> Webdav (Bug)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/18/d0ae2572-3770-4781-88e3-4d40e626fd85__webdav_bug.png
> Webdav (Fixed)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/18/de96eb2e-45d8-4388-83b6-77199f677c75__webdav_fixed.png
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150307/a85f00dc/attachment.html>