Review Request 122828: Be more explicit regarding KBookmarks deps

[Hrvoje Senjan]

> On March 6, 2015, 12:26 a.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 37
> > <https://git.reviewboard.kde.org/r/122828/diff/1/?file=353021#file353021line37>
> >
> >     The find_package shouldn't change, why does it need KConfig now? Isn't it pulled by KConfigWidgets?

it is pulled in, but the review _is_ 'be more explicit...' ;-) i can remove the find_package call if wanted


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122828/#review77071
-----------------------------------------------------------


On March 5, 2015, 8:41 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122828/
> -----------------------------------------------------------
> 
> (Updated March 5, 2015, 8:41 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kbookmarks
> 
> 
> Description
> -------
> 
> this adds KWidetsAddons to public linker flags, but also reduces number of frameworks needed for KBookmarks to be useable.
> removal of kconfig.h could be considered a minor SiC, though e.g. kio & kio-extras built fine with this change
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4b5a25c 
>   KF5BookmarksConfig.cmake.in 8a14d7d 
>   src/CMakeLists.txt 23e3709 
>   src/kbookmarkimporter.h 3f15040 
>   src/kbookmarkmanager.cpp 7c5fa2d 
> 
> Diff: https://git.reviewboard.kde.org/r/122828/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150306/979fa403/attachment-0001.html>