Review Request 122828: Be more explicit regarding KBookmarks deps
Aleix Pol Gonzalez
aleixpol at kde.org
Thu Mar 5 23:26:16 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122828/#review77071
-----------------------------------------------------------
CMakeLists.txt
<https://git.reviewboard.kde.org/r/122828/#comment52973>
The find_package shouldn't change, why does it need KConfig now? Isn't it pulled by KConfigWidgets?
+1.
Removing an include has happened before in a couple of places already, both in Qt and KF5. I don't think it's a big problem.
- Aleix Pol Gonzalez
On March 5, 2015, 8:41 p.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122828/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 8:41 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kbookmarks
>
>
> Description
> -------
>
> this adds KWidetsAddons to public linker flags, but also reduces number of frameworks needed for KBookmarks to be useable.
> removal of kconfig.h could be considered a minor SiC, though e.g. kio & kio-extras built fine with this change
>
>
> Diffs
> -----
>
> CMakeLists.txt 4b5a25c
> KF5BookmarksConfig.cmake.in 8a14d7d
> src/CMakeLists.txt 23e3709
> src/kbookmarkimporter.h 3f15040
> src/kbookmarkmanager.cpp 7c5fa2d
>
> Diff: https://git.reviewboard.kde.org/r/122828/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150305/8b547629/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list