Review Request 122755: Add testcases for KIO::del()

Martin Blumenstingl martin.blumenstingl at googlemail.com
Sun Mar 1 12:21:01 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122755/
-----------------------------------------------------------

(Updated March 1, 2015, 12:21 p.m.)


Review request for KDE Frameworks.


Changes
-------

* Use unicode escaping for the German umlaut and Chinese character testcases
* Use KJob::NoError instead of a hardcoded 0


Repository: kio


Description
-------

This adds some automated testcases for KIO::del().

My own code was buggy but I didn't notice this until I wrote those tests.
Maybe you want to have them upstream to make sure noone breaks KIO::del.


Diffs (updated)
-----

  autotests/deletejobtest.cpp PRE-CREATION 
  autotests/CMakeLists.txt f613c1a 
  autotests/deletejobtest.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122755/diff/


Testing
-------

Tests are passing


Thanks,

Martin Blumenstingl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150301/a630c9a1/attachment.html>


More information about the Kde-frameworks-devel mailing list