Review Request 122755: Add testcases for KIO::del()
Aleix Pol Gonzalez
aleixpol at kde.org
Sun Mar 1 02:34:13 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122755/#review76790
-----------------------------------------------------------
Ship it!
Looks good to me, can you push yourself?
autotests/deletejobtest.cpp
<https://git.reviewboard.kde.org/r/122755/#comment52862>
Would it be better to use the unicode escaping? This can look weird in some set ups?
- Aleix Pol Gonzalez
On Feb. 28, 2015, 10:21 p.m., Martin Blumenstingl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122755/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2015, 10:21 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> This adds some automated testcases for KIO::del().
>
> My own code was buggy but I didn't notice this until I wrote those tests.
> Maybe you want to have them upstream to make sure noone breaks KIO::del.
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt f613c1a
> autotests/deletejobtest.h PRE-CREATION
> autotests/deletejobtest.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/122755/diff/
>
>
> Testing
> -------
>
> Tests are passing
>
>
> Thanks,
>
> Martin Blumenstingl
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150301/a646ee9c/attachment.html>
More information about the Kde-frameworks-devel
mailing list