Review Request 124128: KDirWatch: Only establish a connection to FAM if requested

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124128/#review81881
-----------------------------------------------------------



src/lib/io/kdirwatch.cpp (line 176)
<https://git.reviewboard.kde.org/r/124128/#comment56240>

    This needs to be in a #if HAVE_FAM block, sn and use_fam don't exist otherwise.



src/lib/io/kdirwatch.cpp (line 634)
<https://git.reviewboard.kde.org/r/124128/#comment56241>

    missing a "return false;" after this line, no? It failed, don't proceed.



src/lib/io/kdirwatch.cpp (line 1010)
<https://git.reviewboard.kde.org/r/124128/#comment56242>

    Unnecessary check, if m_mode==FAMMode then sn is not null (well, after adding the return false above ;).


- David Faure


On June 29, 2015, 4:40 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124128/
> -----------------------------------------------------------
> 
> (Updated June 29, 2015, 4:40 p.m.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> KDirWatch by default initializes a connection to both inotify and FAM,
> even if we aren't going to be using either. This is unnecessary and the
> FAM backend has caused it to block for a while on running FAMOpen.
> 
> 
> Diffs
> -----
> 
>   src/lib/io/kdirwatch.cpp 246be82 
> 
> Diff: https://git.reviewboard.kde.org/r/124128/diff/
> 
> 
> Testing
> -------
> 
> Unit tests pass
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150630/1f364e4d/attachment-0001.html>