Review Request 124128: KDirWatch: Only establish a connection to FAM if requested

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124128/
-----------------------------------------------------------

(Updated June 29, 2015, 4:40 p.m.)


Review request for KDE Frameworks and David Edmundson.


Changes
-------

Call FAMOpen on first use.


Repository: kcoreaddons


Description
-------

KDirWatch by default initializes a connection to both inotify and FAM,
even if we aren't going to be using either. This is unnecessary and the
FAM backend has caused it to block for a while on running FAMOpen.


Diffs (updated)
-----

  src/lib/io/kdirwatch.cpp 246be82 

Diff: https://git.reviewboard.kde.org/r/124128/diff/


Testing
-------

Unit tests pass


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150629/0bba8fd1/attachment.html>