Review Request 124208: Fallback for componentFriendlyForAction name resolving
Harald Sitter
sitter at kde.org
Mon Jun 29 11:58:41 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124208/#review81855
-----------------------------------------------------------
Ship it!
Ship It!
- Harald Sitter
On June 29, 2015, 9:18 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124208/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 9:18 a.m.)
>
>
> Review request for KDE Frameworks and Harald Sitter.
>
>
> Repository: kglobalaccel
>
>
> Description
> -------
>
> Currently the name is resolved from an undocumented dynamic property
> which gets set by KActionCollection (xmlgui). If one uses KGlobalAccel
> without using KActionCollection one would have to know the name of
> the private property.
>
> To provide a better name the method performs the same fallbacks as
> KActionCollection. If the property is not set, it uses either the
> application display name or the application name.
>
>
> Diffs
> -----
>
> src/kglobalaccel.cpp 6838bbcfd91d690c067b12db133b6abca5f24203
>
> Diff: https://git.reviewboard.kde.org/r/124208/diff/
>
>
> Testing
> -------
>
> KWin's component now reported properly as "KWin". (KWin is the testcase as it doesn't use xmlgui.)
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150629/915517e9/attachment.html>
More information about the Kde-frameworks-devel
mailing list