Review Request 124208: Fallback for componentFriendlyForAction name resolving

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124208/
-----------------------------------------------------------

Review request for KDE Frameworks and Harald Sitter.


Repository: kglobalaccel


Description
-------

Currently the name is resolved from an undocumented dynamic property
which gets set by KActionCollection (xmlgui). If one uses KGlobalAccel
without using KActionCollection one would have to know the name of
the private property.

To provide a better name the method performs the same fallbacks as
KActionCollection. If the property is not set, it uses either the
application display name or the application name.


Diffs
-----

  src/kglobalaccel.cpp 6838bbcfd91d690c067b12db133b6abca5f24203 

Diff: https://git.reviewboard.kde.org/r/124208/diff/


Testing
-------

KWin's component now reported properly as "KWin". (KWin is the testcase as it doesn't use xmlgui.)


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150629/5b01cded/attachment.html>