Review Request 124150: Fix KCoreAddons build on Clang+ARM

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124150/#review81689
-----------------------------------------------------------

Ship it!


I'd prefer `unsigned long` to `unsigned long int` (the `int`) is redundant, but either way it works for me. Please commit, any further discussion can happen when kcoreaddons builds again on ARM. :)

- Michael Pyne


On June 22, 2015, 5:13 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124150/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 5:13 p.m.)
> 
> 
> Review request for KDE Frameworks and Rohan Garg.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Tries to address the issue pointed out by Rohan.
> 
> We have a set of reverse-engineered literals and one of them we're specifying it as unsigned (the rest are smaller, so it doesn't make a difference), even though the API returns a signed int.
> 
> 
> Diffs
> -----
> 
>   src/lib/io/kfilesystemtype.cpp e4043e4 
> 
> Diff: https://git.reviewboard.kde.org/r/124150/diff/
> 
> 
> Testing
> -------
> 
> Still compiles in the comfortable amd64+g++.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150623/f81894ad/attachment.html>