Review Request 124150: Fix KCoreAddons build on Clang+ARM

Aleix Pol Gonzalez aleixpol at kde.org
Mon Jun 22 17:13:59 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124150/#review81662
-----------------------------------------------------------


Rohan, can you test it on the offended platform? (compile and ideally run tests)
I'm not sure how portable these values are anyway...

- Aleix Pol Gonzalez


On June 22, 2015, 7:13 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124150/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 7:13 p.m.)
> 
> 
> Review request for KDE Frameworks and Rohan Garg.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Tries to address the issue pointed out by Rohan.
> 
> We have a set of reverse-engineered literals and one of them we're specifying it as unsigned (the rest are smaller, so it doesn't make a difference), even though the API returns a signed int.
> 
> 
> Diffs
> -----
> 
>   src/lib/io/kfilesystemtype.cpp e4043e4 
> 
> Diff: https://git.reviewboard.kde.org/r/124150/diff/
> 
> 
> Testing
> -------
> 
> Still compiles in the comfortable amd64+g++.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150622/34da1126/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list