Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

[Matthew Dawson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123872/#review81646
-----------------------------------------------------------

Ship it!


LGTM, thanks for adding the unit tests!  I have just one minor nitpick below (no need to repost the patch).  Also please be sure to include a Changelog: line in the commit message.


autotests/kconfig_compiler/test_translation.kcfg (line 4)
<https://git.reviewboard.kde.org/r/123872/#comment55962>

    Nitpick: trailing space


- Matthew Dawson


On June 21, 2015, 4:47 p.m., Chusslove Illich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123872/
> -----------------------------------------------------------
> 
> (Updated June 21, 2015, 4:47 p.m.)
> 
> 
> Review request for KDE Frameworks, Alexander Potashev and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> When using Ki18n as the translation system, library .kcfg files also need to specify the translation domain. This is analogous to the TRANSLATION_DOMAIN define in C++ code, and translationDomain attribute in .rc files.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfig_compiler/CMakeLists.txt f73aec0 
>   autotests/kconfig_compiler/kconfigcompiler_test.cpp 77a31a3 
>   autotests/kconfig_compiler/klocalizedstring.h e69de29 
>   autotests/kconfig_compiler/test_translation.kcfg e69de29 
>   autotests/kconfig_compiler/test_translation_kde.cpp.ref e69de29 
>   autotests/kconfig_compiler/test_translation_kde.h.ref e69de29 
>   autotests/kconfig_compiler/test_translation_kde.kcfgc e69de29 
>   autotests/kconfig_compiler/test_translation_kde_domain.cpp.ref e69de29 
>   autotests/kconfig_compiler/test_translation_kde_domain.h.ref e69de29 
>   autotests/kconfig_compiler/test_translation_kde_domain.kcfgc e69de29 
>   autotests/kconfig_compiler/test_translation_kde_domain_main.cpp e69de29 
>   autotests/kconfig_compiler/test_translation_kde_main.cpp e69de29 
>   autotests/kconfig_compiler/test_translation_qt.cpp.ref e69de29 
>   autotests/kconfig_compiler/test_translation_qt.h.ref e69de29 
>   autotests/kconfig_compiler/test_translation_qt.kcfgc e69de29 
>   autotests/kconfig_compiler/test_translation_qt_main.cpp e69de29 
>   src/kconfig_compiler/kconfig_compiler.cpp 7160bb5 
> 
> Diff: https://git.reviewboard.kde.org/r/123872/diff/
> 
> 
> Testing
> -------
> 
> Compiles.
> 
> 
> Thanks,
> 
> Chusslove Illich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150622/d57210a4/attachment.html>