<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123872/">https://git.reviewboard.kde.org/r/123872/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">LGTM, thanks for adding the unit tests! I have just one minor nitpick below (no need to repost the patch). Also please be sure to include a Changelog: line in the commit message.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123872/diff/2/?file=380924#file380924line4" style="color: black; font-weight: bold; text-decoration: underline;">autotests/kconfig_compiler/test_translation.kcfg</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> xsi:schemaLocation="http://www.kde.org/standards/kcfg/1.0<span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Nitpick: trailing space</p></pre>
</div>
</div>
<br />
<p>- Matthew Dawson</p>
<br />
<p>On June 21st, 2015, 4:47 p.m. EDT, Chusslove Illich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Alexander Potashev and Matthew Dawson.</div>
<div>By Chusslove Illich.</div>
<p style="color: grey;"><i>Updated June 21, 2015, 4:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When using Ki18n as the translation system, library .kcfg files also need to specify the translation domain. This is analogous to the TRANSLATION_DOMAIN define in C++ code, and translationDomain attribute in .rc files.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiles.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kconfig_compiler/CMakeLists.txt <span style="color: grey">(f73aec0)</span></li>
<li>autotests/kconfig_compiler/kconfigcompiler_test.cpp <span style="color: grey">(77a31a3)</span></li>
<li>autotests/kconfig_compiler/klocalizedstring.h <span style="color: grey">(e69de29)</span></li>
<li>autotests/kconfig_compiler/test_translation.kcfg <span style="color: grey">(e69de29)</span></li>
<li>autotests/kconfig_compiler/test_translation_kde.cpp.ref <span style="color: grey">(e69de29)</span></li>
<li>autotests/kconfig_compiler/test_translation_kde.h.ref <span style="color: grey">(e69de29)</span></li>
<li>autotests/kconfig_compiler/test_translation_kde.kcfgc <span style="color: grey">(e69de29)</span></li>
<li>autotests/kconfig_compiler/test_translation_kde_domain.cpp.ref <span style="color: grey">(e69de29)</span></li>
<li>autotests/kconfig_compiler/test_translation_kde_domain.h.ref <span style="color: grey">(e69de29)</span></li>
<li>autotests/kconfig_compiler/test_translation_kde_domain.kcfgc <span style="color: grey">(e69de29)</span></li>
<li>autotests/kconfig_compiler/test_translation_kde_domain_main.cpp <span style="color: grey">(e69de29)</span></li>
<li>autotests/kconfig_compiler/test_translation_kde_main.cpp <span style="color: grey">(e69de29)</span></li>
<li>autotests/kconfig_compiler/test_translation_qt.cpp.ref <span style="color: grey">(e69de29)</span></li>
<li>autotests/kconfig_compiler/test_translation_qt.h.ref <span style="color: grey">(e69de29)</span></li>
<li>autotests/kconfig_compiler/test_translation_qt.kcfgc <span style="color: grey">(e69de29)</span></li>
<li>autotests/kconfig_compiler/test_translation_qt_main.cpp <span style="color: grey">(e69de29)</span></li>
<li>src/kconfig_compiler/kconfig_compiler.cpp <span style="color: grey">(7160bb5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123872/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>