Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

[Sebastian Kügler]

> On June 20, 2015, 7:10 p.m., Martin Klapetek wrote:
> > +1 for adding all that info
> > -1 for putting it into its own tab; previously it was visible right away, now an additional click is needed. Maybe it could be stacked all under the application name? I mean it's just 2 more lines to add there...

Putting more and more versions there doesn't scale. Just cramming more and more stuff in there doesn't really make it more beautiful, putting it into its own tab means that the information is neatly organized.

Also, the version is really an implementation detail, and having one version there will often yield another round of asking ("Which versions are you running? - "version x.y.z" - "No, I need the versions that are shown in the tab, so also frameworks, Qt, and whether it runs on wayland or X11."


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124133/#review81603
-----------------------------------------------------------


On June 20, 2015, 4:30 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124133/
> -----------------------------------------------------------
> 
> (Updated June 20, 2015, 4:30 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> This replaces the version information of the version and frameworks and
> moves it into a dedicated tab. In this tab the information is extended
> by the Qt version (which is equally relevant as e.g. the frameworks
> version) in both runtime and compile time.
> 
> Also windowing system is added. This will become a useful information
> for KWin developers starting in Plasma 5.4 when users start to test
> things out and we need to know whether the window they experience the
> problem with is running on wayland or xwayland.
> 
> 
> Diffs
> -----
> 
>   src/kaboutapplicationdialog.cpp 5eeea7711aa4f95a9cd4191d68ad330ef795caea 
> 
> Diff: https://git.reviewboard.kde.org/r/124133/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> New wayland, new X11, old X11
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/20/b76ba6ae-b01c-4c6a-9248-29d39c652d83__snapshot_J11265.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150620/0fd9b216/attachment.html>