<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124133/">https://git.reviewboard.kde.org/r/124133/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 20th, 2015, 7:10 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 for adding all that info
-1 for putting it into its own tab; previously it was visible right away, now an additional click is needed. Maybe it could be stacked all under the application name? I mean it's just 2 more lines to add there...</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Putting more and more versions there doesn't scale. Just cramming more and more stuff in there doesn't really make it more beautiful, putting it into its own tab means that the information is neatly organized.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, the version is really an implementation detail, and having one version there will often yield another round of asking ("Which versions are you running? - "version x.y.z" - "No, I need the versions that are shown in the tab, so also frameworks, Qt, and whether it runs on wayland or X11."</p></pre>
<br />
<p>- Sebastian</p>
<br />
<p>On June 20th, 2015, 4:30 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated June 20, 2015, 4:30 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kxmlgui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This replaces the version information of the version and frameworks and
moves it into a dedicated tab. In this tab the information is extended
by the Qt version (which is equally relevant as e.g. the frameworks
version) in both runtime and compile time.
Also windowing system is added. This will become a useful information
for KWin developers starting in Plasma 5.4 when users start to test
things out and we need to know whether the window they experience the
problem with is running on wayland or xwayland.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kaboutapplicationdialog.cpp <span style="color: grey">(5eeea7711aa4f95a9cd4191d68ad330ef795caea)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124133/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/20/b76ba6ae-b01c-4c6a-9248-29d39c652d83__snapshot_J11265.png">New wayland, new X11, old X11</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>