Review Request 124105: Adhere a bit better to the spec

[Sune Vuorela]

> On June 15, 2015, 11:38 p.m., Christoph Feck wrote:
> > Could you please describe (or code) a test case? Or point to a bug report?

It was things I stumbled upon while working on https://bugs.kde.org/show_bug.cgi?id=344469 - but unit test attached now.


- Sune


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124105/#review81499
-----------------------------------------------------------


On June 16, 2015, 5:59 a.m., Sune Vuorela wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124105/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 5:59 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Martin Klapetek.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> According to table 2 in the icon theme spec, the Context per directory key is optional, and the Type key defaults to Threshold if not specified. Let's make the code do the same.
> 
> 
> Diffs
> -----
> 
>   autotests/breeze.theme 8aef88d 
>   autotests/kiconloader_unittest.cpp d1a52fc 
>   src/kicontheme.cpp 4f0e522 
> 
> Diff: https://git.reviewboard.kde.org/r/124105/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sune Vuorela
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150616/692f0761/attachment.html>