Review Request 124105: Adhere a bit better to the spec

Sune Vuorela kde at pusling.com
Tue Jun 16 05:59:50 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124105/
-----------------------------------------------------------

(Updated June 16, 2015, 5:59 a.m.)


Review request for KDE Frameworks, David Faure and Martin Klapetek.


Changes
-------

Add space after ,.
Add unit tests.


Repository: kiconthemes


Description
-------

According to table 2 in the icon theme spec, the Context per directory key is optional, and the Type key defaults to Threshold if not specified. Let's make the code do the same.


Diffs (updated)
-----

  autotests/breeze.theme 8aef88d 
  autotests/kiconloader_unittest.cpp d1a52fc 
  src/kicontheme.cpp 4f0e522 

Diff: https://git.reviewboard.kde.org/r/124105/diff/


Testing
-------


Thanks,

Sune Vuorela

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150616/99003274/attachment.html>


More information about the Kde-frameworks-devel mailing list