Review Request 124089: Connected timeout before timer start.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124089/#review81450
-----------------------------------------------------------


startTimer is called many times so doing the connect every time is wrong, and the connect is already done before, so I don't understand this patch.
What problem is it supposed to fix?

- David Faure


On June 12, 2015, 8:27 p.m., Jordan He wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124089/
> -----------------------------------------------------------
> 
> (Updated June 12, 2015, 8:27 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Connected timeout before timer start.
> 
> 
> Diffs
> -----
> 
>   src/widgets/krun.cpp 50660c0a0f103a03d7950aa1f65b60ff796d1825 
> 
> Diff: https://git.reviewboard.kde.org/r/124089/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jordan He
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150613/57c2b15a/attachment.html>