Review Request 124089: Connected timeout before timer start.

David Edmundson david at davidedmundson.co.uk
Fri Jun 12 21:43:21 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124089/#review81433
-----------------------------------------------------------



src/widgets/krun.cpp (line 859)
<https://git.reviewboard.kde.org/r/124089/#comment55804>

    it happens here, just before a startTimer.
    
    In this code path at least you're now connecting twice.


- David Edmundson


On June 12, 2015, 8:27 p.m., Jordan He wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124089/
> -----------------------------------------------------------
> 
> (Updated June 12, 2015, 8:27 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Connected timeout before timer start.
> 
> 
> Diffs
> -----
> 
>   src/widgets/krun.cpp 50660c0a0f103a03d7950aa1f65b60ff796d1825 
> 
> Diff: https://git.reviewboard.kde.org/r/124089/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jordan He
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150612/607fbeff/attachment.html>


More information about the Kde-frameworks-devel mailing list