Review Request 124147: Create Data Dir If it Does Not Exist

David Narváez david.narvaez at computer.org
Thu Jul 23 05:19:48 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124147/
-----------------------------------------------------------

(Updated July 23, 2015, 5:19 a.m.)


Review request for KDE Frameworks.


Changes
-------

Err, I mixed two commits in the previous version


Repository: kio


Description
-------

Prevents a cold start bug when the data dir is not created. Also, by
storing the file name as a member of the KCookieServer class we avoid
calculating it every time cookies are saved.


Diffs (updated)
-----

  src/ioslaves/http/kcookiejar/kcookieserver.h f61c7d0e4da58b805565632cf3dd484445c21275 
  src/ioslaves/http/kcookiejar/kcookieserver.cpp ac585a0b04637c485647564d18a89a75d6c11d97 

Diff: https://git.reviewboard.kde.org/r/124147/diff/


Testing
-------

Restarted kded5 with no file named kcookiejar inside ~/.local/share and with a regular file named kcookiejar in that location.

In my setup, the message box is not showing properly but I am not sure if this is somethign that happens only on my computer or if this is something wrong with the code, can somebody confirm?


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150723/247aa9fb/attachment.html>


More information about the Kde-frameworks-devel mailing list