Review Request 124147: Create Data Dir If it Does Not Exist

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124147/
-----------------------------------------------------------

(Updated July 23, 2015, 5:05 a.m.)


Review request for KDE Frameworks.


Changes
-------

Fixing all missing issues.


Repository: kio


Description
-------

Prevents a cold start bug when the data dir is not created. Also, by
storing the file name as a member of the KCookieServer class we avoid
calculating it every time cookies are saved.


Diffs (updated)
-----

  src/ioslaves/http/kcookiejar/kcookieserver.h f61c7d0e4da58b805565632cf3dd484445c21275 
  src/ioslaves/http/kcookiejar/kcookieserver.cpp ac585a0b04637c485647564d18a89a75d6c11d97 
  src/kcms/kio/kcookiesmain.cpp c4e36ac69e64f0540167e2a68cd8dadde4333450 
  src/kcms/kio/kcookiesmanagement.cpp c041fc2f2e1a162ced43c944baeec1784e0bcca9 
  src/kcms/kio/kcookiespolicies.cpp 7470616a130decb4261698aa4d4dc3da5c68ec22 
  src/kcms/kio/ksaveioconfig.cpp 82ca6d9c90a58190d912f0f0c791c5e229254ec6 

Diff: https://git.reviewboard.kde.org/r/124147/diff/


Testing
-------

Restarted kded5 with no file named kcookiejar inside ~/.local/share and with a regular file named kcookiejar in that location.

In my setup, the message box is not showing properly but I am not sure if this is somethign that happens only on my computer or if this is something wrong with the code, can somebody confirm?


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150723/e1fe0bb2/attachment-0001.html>