Review Request 124319: Add missing licenses

[Martin Gräßlin]

> On July 10, 2015, 2:49 p.m., Martin Gräßlin wrote:
> > absolute no ShipIt. Maintainer veto!
> > 
> > 
> > This needs proper fixing, just changing the license is no solution! Please refer to the discussion I just sent to the mailing list. It would be nice if such important changes don't get pushed after a 3 min review, but at least waited for the maintainer to have a chance to look at it.
> 
> Maximiliano Curia wrote:
>     It's not a change in the license, it just adds the licenses already referenced in the distributed files.

no, there has not to be any GPL licensed files in the distributed sources. If there is, it's a mistake which needs fixing.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124319/#review82328
-----------------------------------------------------------


On July 10, 2015, 2:48 p.m., Maximiliano Curia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124319/
> -----------------------------------------------------------
> 
> (Updated July 10, 2015, 2:48 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> The distributed tarballs include GPL-2 po files (po/bg), and the
> src/runtime/main.cpp file is under LGPL-2 only, thus the included LGPL-2.1
> won't cover it.
> 
> 
> Diffs
> -----
> 
>   COPYING.GPL-2 PRE-CREATION 
>   COPYING.LGPL-2 PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124319/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150710/ba59cdc5/attachment.html>