KFilePlacesModelTest

[David Faure]

CI says:

10:59:57 QDEBUG : KFilePlacesModelTest::testReparse() Expected: ("/home/jenkins", "remote:/", "/", "trash:/", "/media/nfs", "/foreign", "/media/XO-Y4", "/media/floppy0", "/media/cdrom", "/foo")
10:59:57 QDEBUG : KFilePlacesModelTest::testReparse() Got: ("/home/jenkins", "remote:/", "/", "trash:/", "/media/floppy0", "/media/cdrom", "/media/nfs", "/media/XO-Y4", "/foreign", "/foo")
10:59:57 FAIL!  : KFilePlacesModelTest::testReparse() Compared lists differ at index 4.
10:59:57    Actual   (placesUrls()): "/media/floppy0"
10:59:57    Expected (urls): "/media/nfs"
10:59:57    Loc: [/home/jenkins/builds/kio/kf5-qt5/autotests/kfileplacesmodeltest.cpp(186)]

Anyone knows how the ordering is supposed to work in that unittest?

I see that Kévin's commit 25941ce2633d7ec710142c4c5f26e93369a09786 was already about ordering...
but I think the new CI machine is what triggered the above failure.

Locally this test method passes, but the test fails further on, also about ordering:

QDEBUG : KFilePlacesModelTest::testMove() kfileplacesmodeltest(12131)/default KFilePlacesModelTest::testMove: Expected: ("/home/dfaure", "remote:/", "/", "/media/nfs", "/foreign", "/media/XO-Y4", "/media/floppy0", "/media/cdrom", "trash:/")
QDEBUG : KFilePlacesModelTest::testMove() kfileplacesmodeltest(12131)/default KFilePlacesModelTest::testMove: Got: ("/home/dfaure", "remote:/", "/", "trash:/", "/media/nfs", "/foreign", "/media/XO-Y4", "/media/floppy0", "/media/cdrom")
FAIL!  : KFilePlacesModelTest::testMove() Compared lists differ at index 3.
   Actual   (placesUrls()): "trash:/"
   Expected (urls): "/media/nfs"
   Loc: [/d/kde/src/5/frameworks/kio/autotests/kfileplacesmodeltest.cpp(335)]

testPlacesLifecycle() fails because trash:/ is missing, not just an ordering problem.

(Emmanuel: there's also a failure related to bookmarks, could be related to commit e919daeb)



-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5