Review Request 124129: Fix KAuthorized config file loading

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124129/#review81980
-----------------------------------------------------------


Sorry, but the commit log makes no sense at all.

KGlobal::config() used to overlay the app config file with "kdeglobals". This way you can set settings for one app in kapprc and for all apps in "kdeglobals".
KSharedConfig::openConfig() does .... exactly the same.

So it seems very wrong to me to claim a porting bug here.
There may be a bug, but please keep this in mind: reading from KSharedConfig::openConfig() has a number of advantages:
- using an existing parsed kconfig object, rather than parsing kdeglobals by hand everytime one of the methods in this class is called (for lack of a ksharedconfig keeping a ref to kdeglobals itself)
- allowing to set settings either per-app or globally.

The only trick with kdeglobals is usually *writing* to kdeglobals, which requires either to open kdeglobals directly, or to set some flag in writeEntry calls. But this code here is all about reading, right?

-> what's the bug that this is trying to fix exactly?

- David Faure


On June 19, 2015, 7:20 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124129/
> -----------------------------------------------------------
> 
> (Updated June 19, 2015, 7:20 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> This was broken in porting, it used to be KGlobal::config() which opens
> the kdeglobals file, KSharedConfig::openConfig() opens a config file for
> that application, rather than a global file.
> 
> 
> Diffs
> -----
> 
>   src/core/kauthorized.cpp 4280524dd292a464ad577b04ba1a03a52c7868f5 
> 
> Diff: https://git.reviewboard.kde.org/r/124129/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150702/e410a6ca/attachment.html>