<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124129/">https://git.reviewboard.kde.org/r/124129/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry, but the commit log makes no sense at all.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KGlobal::config() used to overlay the app config file with "kdeglobals". This way you can set settings for one app in kapprc and for all apps in "kdeglobals".
KSharedConfig::openConfig() does .... exactly the same.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So it seems very wrong to me to claim a porting bug here.
There may be a bug, but please keep this in mind: reading from KSharedConfig::openConfig() has a number of advantages:
- using an existing parsed kconfig object, rather than parsing kdeglobals by hand everytime one of the methods in this class is called (for lack of a ksharedconfig keeping a ref to kdeglobals itself)
- allowing to set settings either per-app or globally.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The only trick with kdeglobals is usually <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">writing</em> to kdeglobals, which requires either to open kdeglobals directly, or to set some flag in writeEntry calls. But this code here is all about reading, right?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">-> what's the bug that this is trying to fix exactly?</p></pre>
<br />
<p>- David Faure</p>
<br />
<p>On June 19th, 2015, 7:20 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Matthew Dawson.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated June 19, 2015, 7:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This was broken in porting, it used to be KGlobal::config() which opens
the kdeglobals file, KSharedConfig::openConfig() opens a config file for
that application, rather than a global file.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/kauthorized.cpp <span style="color: grey">(4280524dd292a464ad577b04ba1a03a52c7868f5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124129/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>