Review Request 121864: Get rid of KDBusMenuExporter and use DBusMenuExporter directly

Martin Klapetek martin.klapetek at
Tue Jan 20 15:24:28 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 20, 2015, 3:24 p.m.)


This change has been marked as submitted.

Review request for KDE Frameworks.

Repository: knotifications


KDBusMenuExporter seems to exist only to "provide access to KDE icon names" but the code in DBusMenuExporter is virtually the same, so there's no use for KDBusMenuExporter now.

This had a use in kde4 world where it used KIcon, but QIcon now uses KIconEngine on our platform anyway (and also in pre-qt4.7 before QIcon::name() was a thing).


  src/kstatusnotifieritem.cpp 71c17c8 




Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-frameworks-devel mailing list