Review Request 121864: Get rid of KDBusMenuExporter and use DBusMenuExporter directly
Martin Klapetek
martin.klapetek at gmail.com
Mon Jan 5 18:31:32 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121864/
-----------------------------------------------------------
Review request for KDE Frameworks.
Repository: knotifications
Description
-------
KDBusMenuExporter seems to exist only to "provide access to KDE icon names" but the code in DBusMenuExporter is virtually the same, so there's no use for KDBusMenuExporter now.
This had a use in kde4 world where it used KIcon, but QIcon now uses KIconEngine on our platform anyway (and also in pre-qt4.7 before QIcon::name() was a thing).
Diffs
-----
src/kstatusnotifieritem.cpp 71c17c8
Diff: https://git.reviewboard.kde.org/r/121864/diff/
Testing
-------
Thanks,
Martin Klapetek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150105/655d2a0a/attachment.html>
More information about the Kde-frameworks-devel
mailing list