Review Request 122144: Add new overload to KWindowSystem::icon

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122144/#review74335
-----------------------------------------------------------

Ship it!


Ship It!

- Thomas Lübking


On Jan. 19, 2015, 1:45 nachm., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122144/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2015, 1:45 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> The new overload is a special solution for the X11 platform. It takes
> the NETWinInfo as argument to read the information from.
> 
> This significantly reduces the time to fetch icons for users who
> already have a NETWinInfo with the required data. E.g. for the case
> of KWin it can reduce the number of roundtrips to the X Server from
> up to 15 to 0.
> 
> For non-X11 platforms the method just delegates to the method not
> taking the NETWinInfo argument.
> 
> CHANGELOG: New overload to KWindowSystem::icon which reduces roundtrips to X-Server
> 
> 
> Diffs
> -----
> 
>   src/kwindowsystem_p_x11.h 0d4b6ba551776d2fa08030f78226ecdb3c80c889 
>   src/kwindowsystem_x11.cpp bf958ae63b48424fc412405259f082b740928f9a 
>   src/kwindowsystem.h 322322f12dda7279567be8420533ed22cffffd52 
>   src/kwindowsystem.cpp 65d215b6dfbf4df22e871fd7187fface75abb61b 
> 
> Diff: https://git.reviewboard.kde.org/r/122144/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150119/ea682af1/attachment.html>