Review Request 122144: Add new overload to KWindowSystem::icon

Martin Gräßlin mgraesslin at
Mon Jan 19 13:45:27 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 19, 2015, 2:45 p.m.)

Review request for KDE Frameworks.


fixed an unused variable warning.

Repository: kwindowsystem


The new overload is a special solution for the X11 platform. It takes
the NETWinInfo as argument to read the information from.

This significantly reduces the time to fetch icons for users who
already have a NETWinInfo with the required data. E.g. for the case
of KWin it can reduce the number of roundtrips to the X Server from
up to 15 to 0.

For non-X11 platforms the method just delegates to the method not
taking the NETWinInfo argument.

CHANGELOG: New overload to KWindowSystem::icon which reduces roundtrips to X-Server

Diffs (updated)

  src/kwindowsystem_p_x11.h 0d4b6ba551776d2fa08030f78226ecdb3c80c889 
  src/kwindowsystem_x11.cpp bf958ae63b48424fc412405259f082b740928f9a 
  src/kwindowsystem.h 322322f12dda7279567be8420533ed22cffffd52 
  src/kwindowsystem.cpp 65d215b6dfbf4df22e871fd7187fface75abb61b 




Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-frameworks-devel mailing list